Repository navigation
fix(SV): standards-correct BER and metadata-enabled VLAN 0/PCP 4 Quick Start interoperability - #357
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…while retaining historical PCAP negative evidence
…retaining historical PCAP negative evidence
… historical PCAP negative evidence
… Start, retain strict legacy SCL
masarray
changed the title
…rofile in session harness
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct independent ESP32-P4 PCAP evidence
Operator's 2026-11-04 capture: 140,116 SV frames in 35.03s (3999.91fps), 0 missing/duplicate/out-of-order counters, 0 malformed. Every frame is VLAN priority-tagged (VID=0 PCP=4), APPID 0x4000, svID ARSTACK_SV01, 64B 4I+4V instMag/q; the ASDU has no 0x81 dataSet/0x86 smpRate/0x88 smpMod while 0x89 GM identity is present and smpSynch=2 without external traceability. Optional absence is not in itself an IEC violation, but generic Analyzer lacks the reference without SCL.
Actual production fixes
arstack_4i4v_9-2le_metadata_lab.scdwhich matches the user's physical VLAN0 PCP4 and sends optional dataSet + sampleRate/SmpPerSec=4000. It runs through the existing SCL parser/compiler, immutable profile and firmware controlled deploy/readback. Originalarstack_4i4v_9-2le_reference.scdis preserved strictly minimal for legacy interop. Separately opt-in untagged lab fixture also enables metadata for untagged networks.synchSourceId=false. Internal bench GM can at most claim local sync1 after measured phase/MAC; never global sync2 without independently measured global traceability; otherwise 0. Existing explicit lab override remains clearly simulated.--require-metadata/--require-unsynchronizedopt-in; rejects malformed field sizes/duplicate tags, does not fabricate missing fields.Acceptance boundaries
No automatic flashing, STOP or START. Updated SCL is applied only after operator STOP + SCL re-import + deploy/readback + START. Encoding/sync firmware change requires revision-qualified firmware update under existing supervisor STOPPED proof. CI + standalone mocked fixtures do not establish physical relay acceptance. Use PR #3
masarray/SVGenraw analyzer (new preview CI) rather than obsolete screenshotMode: Live / Synthetic locked timebase. Avoid overlapping firmware lifecycle PR #355 and M4 lane.